-
-
Notifications
You must be signed in to change notification settings - Fork 361
Remove deprecated API #3325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dstansby
wants to merge
10
commits into
zarr-developers:main
Choose a base branch
from
dstansby:rm-deprecations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove deprecated API #3325
+54
−1,119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f23f810
to
a646aa7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3325 +/- ##
==========================================
+ Coverage 61.25% 61.54% +0.29%
==========================================
Files 84 82 -2
Lines 9949 9861 -88
==========================================
- Hits 6094 6069 -25
+ Misses 3855 3792 -63
🚀 New features to boost your workflow:
|
c2ec4f0
to
9464a0b
Compare
84a3c9b
to
81a359d
Compare
81a359d
to
0b15805
Compare
0b15805
to
5630cc6
Compare
cfb6368
to
98e069a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3317. I'm going to leave this as draft, because it will probably be easier to manage backports if this is merged as the last thing before a 3.2.0 release, in case any of the removed API needs fixing in 3.1.x. Opening to avoid duplicaiton of work by others.